Skip to content

Create CCA from modeling region API functionality added (with tests) #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 15, 2024
Merged

Create CCA from modeling region API functionality added (with tests) #321

merged 26 commits into from
Jul 15, 2024

Conversation

@ansjdudkows
Copy link
Contributor

@ansjdudkows ansjdudkows commented Jul 5, 2024 •
edited
Loading

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@github-actions github-actions bot added the testing Anything related to tests label Jul 5, 2024
@ansjdudkows ansjdudkows requested a review from anskhanson July 5, 2024 16:26
@ansjdudkows ansjdudkows requested review from anskhanson and removed request for anskhanson July 11, 2024 13:25
@ansjdudkows ansjdudkows force-pushed the joe/create_cca_from_mr branch from 4f088e0 to 4036ead Compare July 12, 2024 16:01
@codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.54237% with 28 lines in your changes missing coverage. Please review.

Project coverage is 57.75%. Comparing base (d5c4054) to head (9e31009).

Files Patch % Lines
src/ansys/sherlock/core/project.py 48.14% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   57.82%   57.75%   -0.08%     
==========================================
  Files          21       21              
  Lines        4185     4244      +59     
==========================================
+ Hits         2420     2451      +31     
- Misses       1765     1793      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anskhanson
anskhanson requested changes Jul 15, 2024
View reviewed changes
ansjmoody
ansjmoody requested changes Jul 15, 2024
View reviewed changes
ansjmoody
ansjmoody requested changes Jul 15, 2024
View reviewed changes
@ansjdudkows ansjdudkows merged commit 1ca31ac into main Jul 15, 2024
@ansjdudkows ansjdudkows deleted the joe/create_cca_from_mr branch July 15, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ansjmoody ansjmoody ansjmoody approved these changes

@anskhanson anskhanson anskhanson approved these changes

Assignees

@ansjdudkows ansjdudkows

Labels

testing Anything related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ansjdudkows @ansjmoody @anskhanson